refactor: ward off evil s#1465
Merged
Merged
Conversation
Contributor
Author
|
Thank you for the review, I will reconsider. 🚀 |
Member
|
@mochiya98 this looks promising! Should be able to swap out the |
Contributor
Author
|
I fixed the mistake. |
Contributor
Author
|
Any updates on this? |
JoviDeCroock
approved these changes
Apr 4, 2019
Member
There was a problem hiding this comment.
This looks good to me, thanks for working on this @mochiya98. I'm going to wait for another maintainer to voice an opinion but great work already 💯
# Conflicts: # src/diff/index.js
Contributor
Author
|
Is there any problem? I can help if you need. |
marvinhagemeister
approved these changes
Apr 22, 2019
Contributor
Author
|
Great work, thanks for all reviewers! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
booyah!! ✨
fixes #1461