update tests

JoviDeCroock · JoviDeCroock · commit a691cd5c0570 · 2021-12-03T20:47:13.000+01:00
diff --git a/src/diff/catch-error.js b/src/diff/catch-error.js
@@ -16,11 +16,13 @@ export function _catchError(error, vnode) {
 
 				if (ctor && ctor.getDerivedStateFromError != null) {
 					component.setState(ctor.getDerivedStateFromError(error));
+					if (!component._dirty) component.forceUpdate();
 					handled = true;
 				}
 
 				if (component.componentDidCatch != null) {
 					component.componentDidCatch(error);
+					if (!component._dirty) component.forceUpdate();
 					handled = true;
 				}
 
diff --git a/test/browser/lifecycles/getDerivedStateFromError.test.js b/test/browser/lifecycles/getDerivedStateFromError.test.js
@@ -531,7 +531,7 @@ describe('Lifecycle methods', () => {
 
 		it('should bubble on ignored errors', () => {
 			class Adapter extends Component {
-				static getDerivedStateFromError(error) {
+				static getDerivedStateFromError() {
 					// Ignore the error
 					return null;
 				}
@@ -554,9 +554,11 @@ describe('Lifecycle methods', () => {
 				</Receiver>,
 				scratch
 			);
-			rerender();
 
+			rerender();
 			expect(Adapter.getDerivedStateFromError).to.have.been.called;
+
+			rerender();
 			expect(Receiver.getDerivedStateFromError).to.have.been.called;
 			expect(scratch).to.have.property('textContent', 'Error: Error!');
 		});

Original file line number	Diff line number	Diff line change
`@@ -16,11 +16,13 @@ export function _catchError(error, vnode) {`
`16`	`16`
`17`	`17`	`if (ctor && ctor.getDerivedStateFromError != null) {`
`18`	`18`	`component.setState(ctor.getDerivedStateFromError(error));`
	`19`	`+ if (!component._dirty) component.forceUpdate();`
`19`	`20`	`handled = true;`
`20`	`21`	`}`
`21`	`22`
`22`	`23`	`if (component.componentDidCatch != null) {`
`23`	`24`	`component.componentDidCatch(error);`
	`25`	`+ if (!component._dirty) component.forceUpdate();`
`24`	`26`	`handled = true;`
`25`	`27`	`}`
`26`	`28`