Conversation
… it is an array For TDB >= 69
Make `original_type` point to its element type rather than its own type for array-like object
|
I think maybe I should tag @Synthlight and @czastack as this change could break the software that makes use of the rsz dump. I don't know if the change of this PR. If this causes trouble for you guys, adding a new entry like |
|
Running it with RE2 generation & tests (because it's like 5% the size of MHSW and therefore easier to test) and it doesn't seem to break anything for my editor, and the same number of files pass tests afterwards, so no issues there.
It does need some minor fixing for MHWS, but it didn't take too long, and actually passes more tests now (64213 -> 64303, count slightly doubled because of separate read/write tests). If anyone wants an example of the So, from an editor perspective, this appears to work better in the long run. |
Note that this is a breaking change.
element_type_nametoil2cpp_dump.jsonif it is an array-like object and TDB >= 69 (tested with MHWilds OBT only).Structdata type to the rsz dump. Previously, if it was aStructtype, the dumper would unpack it and flatten it into multiple fields. However, for an array ofStruct, the dumper would skip it. This change will unpack a singleStructtype as before but will leave theStructtype untouched if it is an array ofStruct, with hardcoded Size and Alignment set to 1, 1.original_typehas changed. For array objects, it points to their element type instead of their own type. For example, for an array of int, it was"original_type": "System.UInt32[]"before, but it is"original_type": "System.UInt32"after.