Avoid ast.Str for python 3.14 compatibility#51
Closed
jamesjer wants to merge 1 commit intopradyunsg:mainfrom
Closed
Avoid ast.Str for python 3.14 compatibility#51jamesjer wants to merge 1 commit intopradyunsg:mainfrom
jamesjer wants to merge 1 commit intopradyunsg:mainfrom
Conversation
Owner
|
Whelp, I should've looked at open PRs. 🙈 I ended up fixing this independently in adeb375, which I'm noticing now wasn't cleanly split out when I was splitting up all my local work. 🤦🏽 Thanks @jamesjer for filing this PR -- it's appreciated, even if I ended up solving this independently due to myself being slow to catch up on these things. 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ast.Strwas deprecated in python 3.8 and has been removed completely in prereleases of python 3.14. This change avoids use of the removed API. In consequence, however, you would have to drop python 3.7 support to merge this.