Fix Ember Data canary ember-try scenario#202
Merged
Conversation
jlami
approved these changes
Nov 11, 2017
Collaborator
jlami
left a comment
There was a problem hiding this comment.
Nice job! This seems to use ember-data 2.18.0-canary
If only there was a way to move away from bower for ember-source, but I guess the compile/package step is holding us back for that. The current setup will work for now. Thanks for your changes!
Collaborator
Author
|
I don’t mind that much because we’re only needing to use it for tests, with no actual |
Collaborator
|
Yeah, that is true. But I now @broerse would like to have no mention of bower at all 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.