Change access to db property to use Ember.get#84
Merged
rsutphin merged 1 commit intopouchdb-community:masterfrom Jul 29, 2015
Merged
Change access to db property to use Ember.get#84rsutphin merged 1 commit intopouchdb-community:masterfrom
rsutphin merged 1 commit intopouchdb-community:masterfrom
Conversation
Collaborator
|
@jkleinsc, thanks for this. It's a good idea. Can you rebase to get rid of that merge commit? If not I'll take care of it in the next few days. |
…cted Using this.db doesn’t work when injecting a PouchDB into the adapter. In the case of an injected property, you need to use this.get(‘db’).
Collaborator
Author
|
@rsutphin I rebased and got rid of the merge commit. Thanks! |
rsutphin
added a commit
that referenced
this pull request
Jul 29, 2015
Change access to db property to use Ember.get
Collaborator
|
Thanks! |
Collaborator
|
Released as 2.0.3. |
rsutphin
added a commit
that referenced
this pull request
Jul 30, 2015
Member
|
👍, thanks for the PR! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now in the ember adapter, the code is using this.db to reference the PouchDB used. For most use cases this works fine, but it doesn't work if you are trying to set the db via injection doing something like this:
In the example above this.db will be undefined, but this.get('db') will return the defined PouchDB.
This pull request simply changes the this.db references to this.get('db') so that the PouchDB can be injected or can be used the way it is defined in the readme.