Skip to content

Replaced usage of double quotes with single quotes in entire curl snippet#92

Merged
umeshp7 merged 3 commits intofeature/newman-testfrom
feature/curl-doublequotes-to-singlequotes
Sep 12, 2019
Merged

Replaced usage of double quotes with single quotes in entire curl snippet#92
umeshp7 merged 3 commits intofeature/newman-testfrom
feature/curl-doublequotes-to-singlequotes

Conversation

@shreys7
Copy link
Member

@shreys7 shreys7 commented Sep 4, 2019

This fixes #72
This will improve the readability of curl command as previously entire JSON body used to have double quotes and we used to escape each and every double quote, as --data used double quotes to define data.

@shreys7 shreys7 requested a review from umeshp7 September 4, 2019 12:20
@umeshp7
Copy link
Contributor

umeshp7 commented Sep 8, 2019

@shreys7
Some conflicts to be resolved.

@abhijitkane
Copy link
Member

@shreys7 What's the update on this?

@shreys7
Copy link
Member Author

shreys7 commented Sep 10, 2019

@abhijitkane Looked up various resources and everywhere it is mentioned that to escape single quotes inside single quotes, curl has this specification of using '\''

@umeshp7 umeshp7 changed the base branch from develop to feature/newman-test September 12, 2019 12:43
@umeshp7 umeshp7 merged commit 5d5b0f4 into feature/newman-test Sep 12, 2019
@umeshp7 umeshp7 deleted the feature/curl-doublequotes-to-singlequotes branch September 27, 2019 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants