Update deepinstall.js to fix pnpm install#778
Merged
aman-v-singh merged 1 commit intopostmanlabs:developfrom Feb 17, 2025
Merged
Update deepinstall.js to fix pnpm install#778aman-v-singh merged 1 commit intopostmanlabs:developfrom
aman-v-singh merged 1 commit intopostmanlabs:developfrom
Conversation
|
@aman-v-singh could I would very much appreciate if this PR could be merged! I'm running into this issue myself, and preventing post install scripts from being run automatically doesn't feel optimal |
|
Got it.
Sent from Yahoo Mail for iPhone
On Friday, February 7, 2025, 9:08 PM, barak-bem ***@***.***> wrote:
@aman-v-singh could I would very much appreciate if this PR could be merged! I'm running into this issue myself, and preventing post install scripts from being run automatically doesn't feel optimal
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pnpm installfrom a subproject in a project with apnpm-workspace.yamlinstalls the workspaces' dependencies, not the subproject even if that subproject is not part of the workspace. That is causing the postinstall script to hang in some cases. This change tellspnpmto ignore the parent workspace making it work as expected.Closes #772
See: pnpm/pnpm#2412