Skip to content

Feature/kotlin okhttp code gen#490

Merged
dhwaneetbhatt merged 16 commits intopostmanlabs:developfrom
nilsjr:feature/kotlin-okhttp-code-gen
Mar 14, 2023
Merged

Feature/kotlin okhttp code gen#490
dhwaneetbhatt merged 16 commits intopostmanlabs:developfrom
nilsjr:feature/kotlin-okhttp-code-gen

Conversation

@nilsjr
Copy link
Contributor

@nilsjr nilsjr commented May 21, 2021

Here it is. Kotlin OkHttp code generator.

Resolves #491

@nilsjr nilsjr marked this pull request as ready for review May 22, 2021 15:52
@nilsjr
Copy link
Contributor Author

nilsjr commented Jan 30, 2022

Hey is it possible to get a decision to merge it or not?

@dhwaneetbhatt
Copy link

Thank you for contributing @nilsjr. We will be reviewing this PR in the next 2 weeks, and suggest any improvements with the aim of merging.

@dhwaneetbhatt dhwaneetbhatt self-requested a review March 7, 2023 12:20
Copy link

@dhwaneetbhatt dhwaneetbhatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nilsjr requested some minor changes. Also, could you please update your fork with the latest upstream changes from develop? We have some changes in CI (moved to GitHub actions) and would want a green CI check before merging the PR.

@nilsjr
Copy link
Contributor Author

nilsjr commented Mar 9, 2023

Yes will update the pull request in the next days. Almost 2 years old this one :D

@nilsjr nilsjr requested a review from dhwaneetbhatt March 12, 2023 09:42
@nilsjr
Copy link
Contributor Author

nilsjr commented Mar 12, 2023

@dhwaneetbhatt Updated and ready to review. Lets see if the workflow is running :D

@nilsjr nilsjr requested a review from dhwaneetbhatt March 13, 2023 08:35
@dhwaneetbhatt dhwaneetbhatt merged commit 25df1ba into postmanlabs:develop Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Support for Kotlin OkHttp code gen

2 participants