Feature/kotlin okhttp code gen#490
Merged
dhwaneetbhatt merged 16 commits intopostmanlabs:developfrom Mar 14, 2023
Merged
Conversation
added 8 commits
May 21, 2021 14:22
Contributor
Author
|
Hey is it possible to get a decision to merge it or not? |
|
Thank you for contributing @nilsjr. We will be reviewing this PR in the next 2 weeks, and suggest any improvements with the aim of merging. |
dhwaneetbhatt
suggested changes
Mar 9, 2023
There was a problem hiding this comment.
@nilsjr requested some minor changes. Also, could you please update your fork with the latest upstream changes from develop? We have some changes in CI (moved to GitHub actions) and would want a green CI check before merging the PR.
Contributor
Author
|
Yes will update the pull request in the next days. Almost 2 years old this one :D |
Contributor
Author
|
@dhwaneetbhatt Updated and ready to review. Lets see if the workflow is running :D |
dhwaneetbhatt
approved these changes
Mar 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here it is. Kotlin OkHttp code generator.
Resolves #491