Fix encoding when generating HTTP code snippets#455
Merged
webholik merged 2 commits intopostmanlabs:developfrom Feb 19, 2021
sausa28:develop
Merged
Fix encoding when generating HTTP code snippets#455webholik merged 2 commits intopostmanlabs:developfrom sausa28:develop
webholik merged 2 commits intopostmanlabs:developfrom
sausa28:develop
Conversation
webholik
approved these changes
Feb 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #454, to fix HTTP code snippets built using the x-www-form-urlencoded builder.
I have added a new function in util.js specifically to uri-encode the key-values, and updated the http unit tests to match the expected behaviour. I welcome any feedback on the implementation!