Add optional import of FoundationNetworking in swift codegen to make it work with Swift 5.x#354
Merged
Add optional import of FoundationNetworking in swift codegen to make it work with Swift 5.x#354
Conversation
Contributor
|
Can we test this somehow using the newman test? |
Contributor
Author
|
@umeshp7 We are running Swift 5.0.1 for newman tests. The changes happened in Swift 5.1. Perhaps we could change |
Contributor
|
@webholik yes we can update it to 5.1 |
d58221c to
3d659bb
Compare
umeshp7
approved these changes
Oct 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #353.