Skip to content

[Snyk] Upgrade postman-collection from 3.5.1 to 3.6.7#344

Merged
umeshp7 merged 7 commits intodevelopfrom
snyk-upgrade-45bc2dd5f2f2dce2664e45db20117c85
Oct 20, 2020
Merged

[Snyk] Upgrade postman-collection from 3.5.1 to 3.6.7#344
umeshp7 merged 7 commits intodevelopfrom
snyk-upgrade-45bc2dd5f2f2dce2664e45db20117c85

Conversation

@snyk-bot
Copy link
Contributor

@snyk-bot snyk-bot commented Sep 22, 2020

Snyk has created this PR to upgrade postman-collection from 3.5.1 to 3.6.6.

merge advice
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

  • The recommended version is 16 versions ahead of your current version.
  • The recommended version was released 22 days ago, on 2020-08-31.
Release notes
Package name: postman-collection from postman-collection GitHub release notes
Commit messages
Package name: postman-collection
  • e968d3f Merge branch 'release/3.6.6' into master
  • 05a84d4 Release v3.6.6
  • 292baef Create dependabot.yml
  • 5fa3be6 Merge pull request #1079 from postmanlabs/dependabot/npm_and_yarn/lodash-4.17.20
  • 0a4fe79 Merge pull request #1085 from postmanlabs/dependabot/npm_and_yarn/faker-5.1.0
  • 837e7d0 Bump faker from 4.1.0 to 5.1.0
  • 4a4276b Update CHANGELOG
  • 23dad57 Merge pull request #1081 from sadakchap/bugfix_hasOwnProperty
  • 7615eb8 rerunning tests
  • 99a441d fixed key value pair in PropertyList test
  • dba2dce fixed failing test by calling Object.hasOwnProperty.call()
  • 0b7d407 added test for PropertyList.insert() method & reverted changes
  • 58736b9 Update test/unit/url.test.js
  • 0f3932f rerunning the pipeline
  • 9c7bd1c calling Object.hasOwnProperty directly
  • 20a38ac reverted chnages & added 1 unit test
  • d1cb30c Checking whether key is callable or not
  • b1287a5 Bump lodash from 4.17.19 to 4.17.20
  • 043e8b1 Merge branch 'release/3.6.5' into develop
  • 79cd626 Merge branch 'release/3.6.5'
  • a4a297f Release v3.6.5
  • c2469d9 Update dependencies
  • 257a72b Fix JSDoc
  • f1c7119 Indent TS declaration

Compare

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information:

🧐 View latest project report

🛠 Adjust upgrade PR settings

🔕 Ignore this dependency or unsubscribe from future upgrade PRs

@webholik webholik changed the base branch from master to develop October 1, 2020 13:36
@webholik
Copy link
Contributor

webholik commented Oct 1, 2020

The build was failing earlier because the behavior of toString() function has changed in postman-collection. In 3.5.1 it didn't encode special characters in x-www-form-urlencoded, but now it does. This is also the right behavior. For testing we compare pre-generated snippets against http codegen output, so I have changed the snippets to match the correct output.

@webholik webholik requested a review from umeshp7 October 1, 2020 17:19
@umeshp7
Copy link
Contributor

umeshp7 commented Oct 9, 2020

@webholik There are some conflicts on this. Could please resolve those?

@umeshp7
Copy link
Contributor

umeshp7 commented Oct 10, 2020

Can you check in the changelog diff between 3.5.1 and 3.6.6 for Postman collection ans see if there are any other breaking changes that we need to be aware of apart from toString()?
Also we should check if toString is used in any other codegen and there aren't any unexpected behavior which are not covered in tests.
@webholik

@webholik webholik changed the title [Snyk] Upgrade postman-collection from 3.5.1 to 3.6.6 [Snyk] Upgrade postman-collection from 3.5.1 to 3.6.7 Oct 12, 2020
@umeshp7 umeshp7 merged commit 0267781 into develop Oct 20, 2020
@webholik webholik mentioned this pull request Oct 21, 2020
Merged
@umeshp7 umeshp7 deleted the snyk-upgrade-45bc2dd5f2f2dce2664e45db20117c85 branch December 15, 2020 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@umeshp7 umeshp7 umeshp7 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@snyk-bot @webholik @umeshp7