Skip to content

Add sanitising of quotes in URLs(and paths)#289

Merged
abhijitkane merged 1 commit intodevelopfrom
bugfix/quotes-in-url
Jun 24, 2020
Merged

Add sanitising of quotes in URLs(and paths)#289
abhijitkane merged 1 commit intodevelopfrom
bugfix/quotes-in-url

Conversation

@shreys7
Copy link
Member

@shreys7 shreys7 commented Jun 22, 2020

Fixes postmanlabs/postman-app-support#8674
Single/double quotes were not handled correctly in some of the languages.

Languages affected:

  • cURL
  • Java Unirest
  • NodeJS Native (path)
  • Python http.client
  • Swift

@shreys7 shreys7 requested a review from umeshp7 June 22, 2020 11:59
@abhijitkane
Copy link
Member

abhijitkane commented Jun 23, 2020

@shreys7 were the sanitize functions already written? Also, what would be the correct curl command for curl http://httpbin.org/get?a=a"b'c?

@shreys7
Copy link
Member Author

shreys7 commented Jun 23, 2020

@shreys7 were the sanitize functions already written? Also, what would be the correct curl command for curl http://httpbin.org/get?a=a"b'c?

So, we already had sanitize functions, which basically takes care of escaping a single quote inside a single quote, and the same for double quotes. The sanitization part was present in headers, bodies, etc. But some languages did not have sanitisation of URLs.
for curl http://httpbin.orf/get?a=a"b'c => we put the URL in quotes, and after proper escaping cURL command would look like curl 'http://httpbin.org/get?a=a"b'\''c'

Note: to escape a single quote within a single quote we need to replace a single quote with '\'' for cURL(shell)

@abhijitkane abhijitkane merged commit 7cf1a2d into develop Jun 24, 2020
@umeshp7 umeshp7 deleted the bugfix/quotes-in-url branch October 9, 2020 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Escape quotes in the generated code

2 participants