Adds Content-Length header to HTTP snippets#265
Merged
webholik merged 3 commits intopostmanlabs:developfrom Oct 5, 2020
Merged
Adds Content-Length header to HTTP snippets#265webholik merged 3 commits intopostmanlabs:developfrom
webholik merged 3 commits intopostmanlabs:developfrom
Conversation
- Adds Content-Length header to HTTP snippets when body type is raw and length is nonzero - Modifies expected response and adds Content-Length header where required - adds test to check Content-length header for above case
- removes check for only raw body requests - calculates Content length for all type of body - appends adds content length header if body has nonzero length - adds newline character before form data header for proper formatting - modifies expected-http-message json and adds content length header where required - modifies name for unit test for content-length header
webholik
approved these changes
Oct 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #244 for content length
fixes: postmanlabs/postman-app-support#8531 for concatenation problem (refer changes:3)
HTTP requests require Content-Length header if body exists.
This PR adds Content-length header if body has nonzero length.
Changes: