Removes utf8 encoding from generated snippet (python-requests)#260
Merged
webholik merged 1 commit intopostmanlabs:developfrom Oct 6, 2020
Merged
Conversation
- removes .encode(utf8) from print statement in generated snippet
This was referenced May 27, 2020
webholik
approved these changes
Oct 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #249
RCA
This issue was due to different versions of python. In python 2.x, byte strings are printed without any prefix/suffix unlike the case in python 3.x where resulting byte code is inside
b' string here '.Solution
Removing encoding solves the above issue.
This PR adds the following changes: