Skip to content

Fixed multiple headers with same name issue in js-jquery#134

Merged
umeshp7 merged 1 commit intodevelopfrom
bugfix/jquery-multiple-headers
Nov 25, 2019
Merged

Fixed multiple headers with same name issue in js-jquery#134
umeshp7 merged 1 commit intodevelopfrom
bugfix/jquery-multiple-headers

Conversation

@shreys7
Copy link
Member

@shreys7 shreys7 commented Nov 25, 2019

Screenshot 2019-11-12 at 12 07 24 PM

Multiple headers with the same name caused creating an invalid snippet, because of the same keys in an object. The headers with the same name will be clubbed and kept in an array, i.e.

"sdf": ["sdf", "sdsfg"]

This fixes #124

@shreys7 shreys7 requested a review from umeshp7 November 25, 2019 10:06
@umeshp7 umeshp7 merged commit 315d5f9 into develop Nov 25, 2019
@umeshp7 umeshp7 deleted the bugfix/jquery-multiple-headers branch December 17, 2019 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect code generated for JQuery when multiple headers of the same name are present.

2 participants