Skip to content

Added handling of multiple files in same form data field#123

Merged
umeshp7 merged 19 commits intodevelopfrom
feature/multiple-files-formdata
Nov 18, 2019
Merged

Added handling of multiple files in same form data field#123
umeshp7 merged 19 commits intodevelopfrom
feature/multiple-files-formdata

Conversation

@shreys7
Copy link
Member

@shreys7 shreys7 commented Nov 11, 2019 •
edited
Loading

  • Issue:
    Adding multiple files or zero files causes snippet generation to fail in the documenter.
    This cannot be reproduced in the App.
  • Reason:
    The form data field in request body is an array of objects.
{
    key: 'param key'
    type: 'file' or 'text'
    value: Value of the param is type is text, else an empty string
    src: This property differs what we get in App versus what we get in documenter
}
  • src property always is a string representing a file path in App. When there are multiple files in the same form data param, different params are created for each file path.
  • While in documenter, this is an empty array for 0 files, a string for a single file and an array of strings for multiple files.
  • Hence data.src.split does not work when the input is an array as opposed to string.
  • Before calling the form data parsing function, make sure that it receives src param always a string. Thus, split the src array into different form data params with each containing different file paths.

@shreys7 shreys7 requested a review from umeshp7 November 11, 2019 12:27
@umeshp7
Copy link
Contributor

umeshp7 commented Nov 13, 2019

Need unit/newman test for this fix.

@umeshp7
Copy link
Contributor

umeshp7 commented Nov 18, 2019

@shreys7 Tests failing.

@shreys7
Copy link
Member Author

shreys7 commented Nov 18, 2019

Added newman/unit tests @umeshp7

@umeshp7 umeshp7 merged commit da35768 into develop Nov 18, 2019
@snyk-bot snyk-bot mentioned this pull request Mar 15, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request May 31, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Jun 30, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Oct 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@umeshp7 umeshp7 umeshp7 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shreys7 @umeshp7