raop: Add support for AirPort Express#1098
Merged
Merged
Conversation
A few things had to be fixed: * Verify supported metadata as the AirPort Express only supports progress (sending text yields an error) * Trigger auth-setup needed to set up a connection * Handle RTSP responses split over multiple IP packets (not needed for AirPort Express, but other receivers) Fixes #1077
|
|
Codecov Report
@@ Coverage Diff @@
## master #1098 +/- ##
==========================================
- Coverage 88.75% 88.55% -0.21%
==========================================
Files 57 57
Lines 5424 5460 +36
==========================================
+ Hits 4814 4835 +21
- Misses 610 625 +15
Continue to review full report at Codecov.
|
|
This pull request fixes 1 alert when merging 7f4b417 into a24ee74 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging 643adb2 into 311ca61 - view on LGTM.com fixed alerts:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few things had to be fixed:
progress (sending text yields an error)
AirPort Express, but other receivers)
Fixes #1077