raop: Respect receiver audio properties#1073
Merged
Merged
Conversation
This makes sure that we re-encode and output audio in a format that the receiver expects. Default parameters 44100/2/16bit is used when properties are not present in Zeroconf. A check has also been added that verifies that unencrypted audio is supported by the receiver. Raises an exception otherwise. Fixes #1067
Codecov Report
@@ Coverage Diff @@
## master #1073 +/- ##
==========================================
- Coverage 90.13% 90.02% -0.11%
==========================================
Files 55 56 +1
Lines 5208 5253 +45
==========================================
+ Hits 4694 4729 +35
- Misses 514 524 +10
Continue to review full report at Codecov.
|
|
This pull request introduces 2 alerts when merging 5a5180c into f2c625f - view on LGTM.com new alerts:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes sure that we re-encode and output audio in a format that the
receiver expects. Default parameters 44100/2/16bit is used when
properties are not present in Zeroconf.
A check has also been added that verifies that unencrypted audio is
supported by the receiver. Raises an exception otherwise.
Fixes #1067