Skip to content

raop: Respect receiver audio properties#1073

Merged
postlund merged 1 commit into
masterfrom
raop_props
May 11, 2021
Merged

raop: Respect receiver audio properties#1073
postlund merged 1 commit into
masterfrom
raop_props

Conversation

@postlund

@postlund postlund commented May 11, 2021

Copy link
Copy Markdown
Owner

This makes sure that we re-encode and output audio in a format that the
receiver expects. Default parameters 44100/2/16bit is used when
properties are not present in Zeroconf.

A check has also been added that verifies that unencrypted audio is
supported by the receiver. Raises an exception otherwise.

Fixes #1067

This makes sure that we re-encode and output audio in a format that the
receiver expects. Default parameters 44100/2/16bit is used when
properties are not present in Zeroconf.

A check has also been added that verifies that unencrypted audio is
supported by the receiver. Raises an exception otherwise.

Fixes #1067
@postlund postlund added the raop Remote Audio Output Protocol label May 11, 2021
@postlund postlund added this to the v0.8.0 milestone May 11, 2021
@postlund postlund self-assigned this May 11, 2021
@gitpod-io

gitpod-io Bot commented May 11, 2021

Copy link
Copy Markdown

@codecov

codecov Bot commented May 11, 2021

Copy link
Copy Markdown

Codecov Report

Merging #1073 (5a5180c) into master (f2c625f) will decrease coverage by 0.10%.
The diff coverage is 63.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1073      +/-   ##
==========================================
- Coverage   90.13%   90.02%   -0.11%     
==========================================
  Files          55       56       +1     
  Lines        5208     5253      +45     
==========================================
+ Hits         4694     4729      +35     
- Misses        514      524      +10     
Impacted Files Coverage Δ
pyatv/raop/__init__.py 43.18% <0.00%> (ø)
pyatv/raop/miniaudio.py 32.25% <28.57%> (-4.59%) ⬇️
pyatv/raop/raop.py 27.55% <33.33%> (+0.46%) ⬆️
pyatv/raop/parsers.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2c625f...5a5180c. Read the comment docs.

@lgtm-com

lgtm-com Bot commented May 11, 2021

Copy link
Copy Markdown

This pull request introduces 2 alerts when merging 5a5180c into f2c625f - view on LGTM.com

new alerts:

  • 1 for Membership test with a non-container
  • 1 for Module is imported with 'import' and 'import from'

@postlund postlund merged commit 41b5705 into master May 11, 2021
@postlund postlund deleted the raop_props branch May 11, 2021 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

raop Remote Audio Output Protocol

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Respect audio properties provided by receiver and transcode input audio to match

1 participant