Skip to content

Add initial support for RAOP#1060

Merged
postlund merged 13 commits into
masterfrom
raop
May 11, 2021
Merged

Add initial support for RAOP#1060
postlund merged 13 commits into
masterfrom
raop

Conversation

@postlund

@postlund postlund commented May 6, 2021

Copy link
Copy Markdown
Owner

See #1059.

@gitpod-io

gitpod-io Bot commented May 6, 2021

Copy link
Copy Markdown

@postlund postlund changed the title Add initial support for Add initial support for RAOP May 6, 2021
@codecov

codecov Bot commented May 6, 2021

Copy link
Copy Markdown

Codecov Report

Merging #1060 (998c06b) into master (a93601f) will decrease coverage by 5.74%.
The diff coverage is 41.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1060      +/-   ##
==========================================
- Coverage   95.87%   90.13%   -5.75%     
==========================================
  Files          49       55       +6     
  Lines        4676     5208     +532     
==========================================
+ Hits         4483     4694     +211     
- Misses        193      514     +321     
Impacted Files Coverage Δ
pyatv/convert.py 100.00% <ø> (ø)
pyatv/support/device_info.py 100.00% <ø> (ø)
pyatv/raop/raop.py 27.09% <27.09%> (ø)
pyatv/raop/miniaudio.py 36.84% <36.84%> (ø)
pyatv/raop/rtsp.py 39.86% <39.86%> (ø)
pyatv/raop/__init__.py 43.18% <43.18%> (ø)
pyatv/raop/timing.py 46.66% <46.66%> (ø)
pyatv/support/facade.py 96.62% <66.66%> (-0.53%) ⬇️
pyatv/__init__.py 96.72% <100.00%> (+0.05%) ⬆️
pyatv/conf.py 99.13% <100.00%> (+0.05%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a93601f...998c06b. Read the comment docs.

@postlund postlund force-pushed the raop branch 3 times, most recently from 5331bc4 to 160d539 Compare May 11, 2021 17:50
postlund added 13 commits May 11, 2021 21:53
This commit makes it possible to scan for RAOP services and call the new
stream_file method in the Stream interface. There's no RAOP protocol
implementation yet, so it's not usable.

Relates to #1059
This implementation is merely to demonstrate the functionality.

Relates to #1059
When being late sending packets, send some additional packets in an
attempt to catch up. A maximum of three packets will be sent each packet
interval to not overcompensate too much. A very naive approach but
seems to improve the situation a lot.

Fixes #1061
Refactor how statistics are calculated and provide better output for
easier troubleshooting. One small step towards improved statistics.

Relates to #1059
I will add additional text to protocol documentation for RAOP and
AirPlay over time, but it's not a priority as there are lots of sources
online anyways.

Relates to #1059
@postlund postlund merged commit f2c625f into master May 11, 2021
@postlund postlund deleted the raop branch May 11, 2021 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant