Skip to content

Conversation

@nicolasvan
Copy link
Contributor

To get djc/bb8#186 and djc/bb8#189 which fix potential deadlocks (djc/bb8#154)

@tobyhede
Copy link
Contributor

tobyhede commented Jun 6, 2024

I've done this upgrade on a branch and some of the integration tests fail.
A couple of tests that check pool stats break - I think the pool is not releasing connections in quite the same way as the earlier version.

Anyone else seen this?`

nicolasvan and others added 2 commits October 23, 2024 11:48
To get djc/bb8#186 and djc/bb8#189
which fix potential deadlocks (djc/bb8#154).

Also, this (djc/bb8#225) was needed to prevent a connection
leak which was conveniently spotted in our integration tests.
@magec magec changed the title Bump bb8 from 0.8.1 to 0.8.3 Bump bb8 from 0.8.1 to 0.8.6 Oct 23, 2024
@magec
Copy link
Collaborator

magec commented Oct 23, 2024

I updated the branch so it now updates to 0.8.6 the issue with the test was actually a regression) that got fixed on 0.8.6 /cc @tobyhede

@magec
Copy link
Collaborator

magec commented Oct 28, 2024

We have been running this version for a week already and it seems to be working well (we were hitting deadlocks in pools). I think this is ready to merge /cc @levkk @drdrsh

@drdrsh drdrsh merged commit a68071d into postgresml:main Oct 28, 2024
@magec magec deleted the update-bb8 branch October 28, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants