Skip to content

Fix handling of @charset in media imports#453

Merged
RyanZim merged 1 commit intomasterfrom
ryan/charset-media
Mar 31, 2021
Merged

Fix handling of @charset in media imports#453
RyanZim merged 1 commit intomasterfrom
ryan/charset-media

Conversation

@RyanZim
Copy link
Copy Markdown
Collaborator

@RyanZim RyanZim commented Mar 29, 2021

Fixes #448

@RyanZim RyanZim added the bug label Mar 29, 2021
@RyanZim RyanZim merged commit f85d645 into master Mar 31, 2021
@RyanZim RyanZim deleted the ryan/charset-media branch March 31, 2021 22:48
@mesineni
Copy link
Copy Markdown

mesineni commented Apr 1, 2021

When this fix is available ? which version ?

@RyanZim
Copy link
Copy Markdown
Collaborator Author

RyanZim commented Apr 1, 2021

v14.0.1

@jobi-codework
Copy link
Copy Markdown

I got an issue when upgrading from v8 to v12 and the issue is that i cannot use the custom theme

./src/styles.scss - Error: Module build failed (from ./node_modules/mini-css-extract-plugin/dist/loader.js):
ModuleBuildError: Module build failed (from ./node_modules/sass-loader/dist/cjs.js):
SassError: expected "(".

1254 │ @function mat.get-contrast-color-from-palette($palette, $hue) {
│ ^

@postcss postcss locked as off-topic and limited conversation to collaborators Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Module build failure after upgrade from 12.0.1 to 14.0.0

3 participants