only exit on watch if stdin is TTY#424
Closed
ToppleTheNun wants to merge 1 commit intopostcss:masterfrom
Closed
Conversation
Collaborator
|
This causes tests to fail; please investigate. |
stdin's end event is fired immediately if stdin is not a TTY
|
Could be related to https://github.com/sindresorhus/get-stdin/blob/main/index.js#L4= short-circuit. Endemic to Node projects, there's no reason to be including a dependency for these 8 lines of code that come from |
|
Curious to know if this PR is dead? Running into this same issue with Rails-7 & postcss when we use foreman and background the foreman process. Thanks! Note: the same fix here fixes that issue. |
Collaborator
|
@nickcluc PR welcome that fixes this issue without breaking the test suite. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check if stdin is TTY before checking "end" event,
as non-TTY stdin will always invoke end and exit.
found from running "postcss -w" in a docker container (#370)
and running "postcss -w" in lerna or turborepo.
closes #426