fix: add support for svh, lvh, dvh, svw, lvw, dvw, svmin, lvmin, dvmin, svmax, lvmax, dvmax units#218
Conversation
…n, svmax, lvmax, dvmax units
ludofischer
left a comment
There was a problem hiding this comment.
Thank you! I think we need to still regenerate the parser.
Sorry I'm not familiar enough with the project - not sure I understand. Anything I can assist you with? Also, would you kindly provide an ETA for a push of this commit to production? Thank you |
|
Could you maybe post some sample CSS that you tried to parse, so I can add some tests, just to make sure we don't forget about it if we ever change the parser? |
|
Sure. Here are the lines the plugin is outputting as errors/warning for my project:
Sorry to insist, but do you have a broad estimation of when that might happen? Thank you. |
If you really need immediately I could do it this evening or tomorrow. Is this issue preventing the minification to complete? I think it's supposed to skip minifying the code it does not understand and output a warning, but it should not crash the program. Or is the warning itself a a problem? |
|
You're correct. The warning is not a problem in itself. I do however need to minify as much code as possible and was under the assumption that the plugin skipping lines was probably hurting its effectiveness.
That's very kind, thank you. I certainly don't mean to be pushy - but yeah when you have a moment for this, it would be much appreciated. |
... as well as vb, svb, lvb, dvb, vi, svi, lvi, dvi.
fix #217
I didn't add tests since you don't have any that's specific to vh and vw.