Add Input#fromLineAndColumn, CssSyntaxError.input.offset and CssSyntaxError.input.endOffset#2034
Merged
ai merged 6 commits intopostcss:mainfrom Mar 22, 2025
Merged
Conversation
ai
reviewed
Mar 22, 2025
mizdra
commented
Mar 22, 2025
|
|
||
| is(error.file, join(__dirname, 'b.css')) | ||
| is(error.line, 2) | ||
| is(error.column, 0) // Is this correct? |
Contributor
Author
There was a problem hiding this comment.
It appears that the columns restored from the sourcemap are smaller by 1. This may be a bug.
I will investigate the details and create an issue.
Member
There was a problem hiding this comment.
OK. Let’s merge it and think about it in separated issues/PRs.
Member
|
Amazing. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: #2022
I initially tried to add
CssSyntaxError.offsetandCssSyntaxError.endOffset. But in the case of CSS with source map, it is always undefined. The sourcemap has the original line and column, but not the offset.Instead, I added
CssSyntaxError.input.offsetandCssSyntaxError.input.endOffset.CssSyntaxError.inputis a property with a location that ignores the sourcemap. I thought it appropriate to addoffsetandendOffsethere.I needed
Input#fromLineAndColumnto implement the properties. So I have added that as a public API.