Fix position calculations when offset is missing
#1983
Merged
+109
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
offset is missing
cd98ca9 to
1f7be7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to : #1980
When testing PostCSS
v8.4.48I got some unexpected errors in Stylelint using thepostcss-sugarsscustom syntax.It seems that this syntax doesn't expose
source.offsetTo avoid unexpected issues in the community I think it is best to add a fallback where we calculate the correct
offsetif this field is not set by the parser.This is slower than directly accessing a pre-computed value but that makes PostCSS more resilient.
(Ideally postcss/sugarss#105 is resolved so that they also have the faster code when linting.)