Replace indexOf === 0 with startsWith#1956
Merged
ai merged 1 commit intopostcss:mainfrom Aug 6, 2024
Juneezee:refactor/replace-indexOf-with-startsWith
Merged
Replace indexOf === 0 with startsWith#1956ai merged 1 commit intopostcss:mainfrom Juneezee:refactor/replace-indexOf-with-startsWith
indexOf === 0 with startsWith#1956ai merged 1 commit intopostcss:mainfrom
Juneezee:refactor/replace-indexOf-with-startsWith
Conversation
It is more readable to call `startsWith` than to call `indexOf` and compare the result with zero to determine whether a string starts with a given prefix. `startsWith` is also more efficient as it only compares at the beginning of the string, while `indexOf` searches the entire string. Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Member
|
Can you run https://github.com/postcss/benchmark before and after the change? |
Contributor
Author
|
Before: After: I updated |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small PR.
It is more readable to call
startsWiththan to callindexOfand compare the result with zero to determine whether a string starts with a given prefix.startsWithis also more efficient as it only compares at the beginning of the string, whileindexOfsearches the entire string.