Fix typo'd setter name in declaration.d.ts#1953
Merged
ai merged 1 commit intopostcss:mainfrom Jul 29, 2024
Merged
Conversation
Member
|
cc @nex3 |
Member
|
In reality I think we could not release this fix since nobody can use broken property. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I just happened to notice this typo whilst reviewing the changes in the most recent release. (Thanks Dependabot!)
This was introduced in #1950.
I'm not familiar with PostCSS's internals or release process. As a release of PostCSS has already gone out with this setter name spelled incorrectly, I'm not sure if this warrants additional work to support the prior name and avoid a breaking change.
Feel free to modify this PR as needed.