Skip to content

Add types for an Input.error()#1811

Merged
ai merged 1 commit intopostcss:mainfrom
hudochenkov:fix-input-types
Jan 6, 2023
Merged

Add types for an Input.error()#1811
ai merged 1 commit intopostcss:mainfrom
hudochenkov:fix-input-types

Conversation

@hudochenkov
Copy link
Copy Markdown
Contributor

Something I found when was developing postcss-styled-syntax.

I didn't find a good way to test if types are correct.

@ai
Copy link
Copy Markdown
Member

ai commented Jan 5, 2023

Will look and take tomorrow

@ai ai merged commit 4ad96d1 into postcss:main Jan 6, 2023
@ai
Copy link
Copy Markdown
Member

ai commented Jan 6, 2023

I fixed types a little c9bd445

@ai
Copy link
Copy Markdown
Member

ai commented Jan 6, 2023

Thanks. Released in 8.4.21.

@hudochenkov hudochenkov deleted the fix-input-types branch January 7, 2023 00:58
@hudochenkov
Copy link
Copy Markdown
Contributor Author

Thanks!

How do you test all types in PostCSS? check-dts doesn't catch all of them. And there is nothing like tsconfig with allowJs.

@ai
Copy link
Copy Markdown
Member

ai commented Jan 7, 2023

How do you test all types in PostCSS?

By writing tests in TS (not case for this method, since it is not really “public”, most users should use Node#error())

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants