Fix ReDoS in previous-map#1567
Merged
ai merged 1 commit intopostcss:mainfrom Apr 26, 2021
yetingli:main
Merged
Conversation
Fix Strategy: Replace `(.*)` with `(?:(?!sourceMappingURL=).)*`
Member
|
Thanks. Released in 8.2.13. |
|
I'm looking at snyk and I don't understand how this would be exploited. Would you somehow need to construct a malicious source map (?) and inject it (?) into someone's build pipeline that uses postcss? |
Member
|
@AndrewRayCode yeap. It could be used on services like CodePen, when users use servers to compile user’s CSS. And it is not a real vulnerability. But a way to increase used resources. Even without fixing PostCSS you can add extra timeout check and kill commands which takes too much time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Strategy: Replace
(.*)with(?:(?!sourceMappingURL=).)*