Added postcss-viewport-height-correction#1323
Merged
ai merged 4 commits intopostcss:masterfrom Feb 8, 2020
Merged
Conversation
postcss-viewport-height-correction solves the popular problem when 100vh doesn’t fit the mobile browser screen.
ai
reviewed
Feb 5, 2020
docs/plugins.md
Outdated
| * [`postcss-autocorrect`] corrects typos and notifies in the console. | ||
| * [`postcss-px-to-viewport`] generates viewport units (`vw`, `vh`, `vmin`, `vmax`) from `px` units. | ||
|
|
||
| * [`postcss-viewport-height-correction`] solves the popular problem when 100vh doesn’t fit the mobile browser screen. |
Member
There was a problem hiding this comment.
100vhshould be as a code:
`100vh`- You need to keep lines in 80 symbols long.
Contributor
Author
There was a problem hiding this comment.
Corrected docs according to the recommendation
ai
reviewed
Feb 5, 2020
docs/plugins.md
Outdated
| * [`postcss-autocorrect`] corrects typos and notifies in the console. | ||
| * [`postcss-px-to-viewport`] generates viewport units (`vw`, `vh`, `vmin`, `vmax`) from `px` units. | ||
|
|
||
| * [`postcss-viewport-height-correction`] "corrects" `100vh` which doesn’t fit the mobile browser screen. |
Member
There was a problem hiding this comment.
Let’s avoid quoted "corrects". User will not understand why it is not normal correct. You can use old description, just split it into two lines.
Contributor
Author
There was a problem hiding this comment.
Does splitting mean? In markdown file or in markdown preview?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
postcss-viewport-height-correction solves the popular problem when 100vh doesn’t fit the mobile browser screen.