Skip to content

[Docs]: Added reference to contributing guidelines#1318

Merged
ai merged 2 commits intopostcss:masterfrom
jamesgeorge007:docs
Jan 7, 2020
Merged

[Docs]: Added reference to contributing guidelines#1318
ai merged 2 commits intopostcss:masterfrom
jamesgeorge007:docs

Conversation

@jamesgeorge007
Copy link
Copy Markdown
Contributor

It is definitely a good idea to provide a reference to the contributing guidelines from the docs that people may miss out if otherwise.

@ai
Copy link
Copy Markdown
Member

ai commented Jan 7, 2020

I didn't add it, because it could be out of context for most of repo visitors.

99% came here to find how to use PostCSS bin their project. In this case “Usage” section is much more important.

Initially I hoped that GitHub will show contribution docs to the users who plan to do contribution in PR UI. Is it stopped to work?

Should we move the link below?

@jamesgeorge007
Copy link
Copy Markdown
Contributor Author

If someone wishes to contribute to any project the first thing he/she would look out for is the contributing docs from which they could get to know regarding the local environment setup and related stuffs. I would say this is definitely worth adding as part of the docs in regard to the previous statement.

@ai
Copy link
Copy Markdown
Member

ai commented Jan 7, 2020

Lens move link below in README

@jamesgeorge007
Copy link
Copy Markdown
Contributor Author

@ai is this what you intended for?

@ai
Copy link
Copy Markdown
Member

ai commented Jan 7, 2020

Yeap. Thanks :)

@ai ai merged commit dabd42a into postcss:master Jan 7, 2020
@jamesgeorge007 jamesgeorge007 deleted the docs branch January 7, 2020 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants