Merge pull request #1932 from romainmenke/fix-warning-end-index--inventive-numbat-fbada42105

ai · web-flow · commit c1ad8fb40249 · 2024-03-20T18:34:07.000+01:00
Fix resulting `end` position when `endIndex` is `0` for `rangeBy`
diff --git a/lib/node.js b/lib/node.js
@@ -241,7 +241,7 @@ class Node {
           column: opts.end.column,
           line: opts.end.line
         }
-      } else if (opts.endIndex) {
+      } else if (typeof opts.endIndex === 'number') {
         end = this.positionInside(opts.endIndex)
       } else if (opts.index) {
         end = this.positionInside(opts.index + 1)
diff --git a/test/warning.test.ts b/test/warning.test.ts
@@ -85,6 +85,24 @@ test('gets range from node without end', () => {
   is(warning.endColumn, 2)
 })
 
+test('gets range from node with endIndex 3', () => {
+  let root = parse('a{}')
+  let warning = new Warning('text', { node: root.first, index: 0, endIndex: 3 })
+  is(warning.line, 1)
+  is(warning.column, 1)
+  is(warning.endLine, 1)
+  is(warning.endColumn, 4)
+})
+
+test('gets range from node with endIndex 0', () => {
+  let root = parse('a{}')
+  let warning = new Warning('text', { node: root.first, index: 0, endIndex: 0 })
+  is(warning.line, 1)
+  is(warning.column, 1)
+  is(warning.endLine, 1)
+  is(warning.endColumn, 2)
+})
+
 test('gets range from word', () => {
   let root = parse('a b{}')
   let warning = new Warning('text', { node: root.first, word: 'b' })

Original file line number	Diff line number	Diff line change
`@@ -241,7 +241,7 @@ class Node {`
`241`	`241`	`column: opts.end.column,`
`242`	`242`	`line: opts.end.line`
`243`	`243`	`}`
`244`		`- } else if (opts.endIndex) {`
	`244`	`+ } else if (typeof opts.endIndex === 'number') {`
`245`	`245`	`end = this.positionInside(opts.endIndex)`
`246`	`246`	`} else if (opts.index) {`
`247`	`247`	`end = this.positionInside(opts.index + 1)`