Open new windows in native tabs if option is set#9159
Conversation
| const forceNewTabbedWindow = this.configurationService.getValue<boolean>('window.nativeTabs'); | ||
| if (forceNewTabbedWindow || options.forceNewTabbedWindow) { | ||
| // --- End Positron --- | ||
| const activeWindow = this.getLastActiveWindow(); |
There was a problem hiding this comment.
Technically I don't think it requires a restart. I tried to change the setting and got prompted to restart but said "no" and it still works as expected. I'm ok with this tradeoff of being extra safe though.
| if (forceNewTabbedWindow || options.forceNewTabbedWindow) { | ||
| // --- End Positron --- | ||
| const activeWindow = this.getLastActiveWindow(); | ||
| activeWindow?.addTabbedWindow(createdWindow); |
There was a problem hiding this comment.
Here's a good video of me running through all the main ways I open a project. It all works as expected.
Something like this would make a good page on the positron docs?
Notably Files: Open Recent which doesn't open in a new window by default, but you can force it to open in a new window by Cmd + Clicking on the project name, and it works well with this option.
Lastly, I don't show it in the video here, but I also personally set "window.openFoldersInNewWindow": "on" because I always want my folders to open in a new tab. This forces the 3 cases of "overwrites current tab" that you see in this video to instead also open in a new tab instead, which I think we should at least document alongside this option, as I think people will find it useful.
Addresses #8731
Release Notes
New Features
window.nativeTabsis set totrue, new windows will now always open in native tabs (Improve native tabs support on macOS #8731). Previously they would only do so if the global macOS setting to always prefer opening in native tabs was also set.Bug Fixes
QA Notes
When
window.nativeTabsis set on macOS, every action that opens a new window should consistently open a native tab.This should be the case even when the following macOS setting is set to "never":