Improve command resolution in !help#73
Merged
devblackops merged 1 commit intoposhbotio:masterfrom Dec 14, 2017
Merged
Conversation
* Look in FullCommandName, Command, Aliases independently, vs. -or comparisons * Use pluginmanager.commands.ModuleCommand to fully qualify get-help call
Member
|
Good catch @RamblingCookieMonster. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed that some
Get-CommandHelpcalls were returning more data than expected (i.e.Manualfield for commands with similar names shows doesn't show expected content with-Examples,-Detailed, or-Full).Description
Related Issue
#67 ish
Motivation and Context
I keep getting output for multiple commands when using
-Detailed,-Full, and-Examples, for certain commandsHow Has This Been Tested?
Manually tested against a variety of commands that previously generated multiple items in the
Manualfield, now see expected contentScreenshots (if appropriate):
Types of changes
Checklist: