Add FormatEnumerationLimitOverride to config#72
Merged
devblackops merged 1 commit intoposhbotio:masterfrom Dec 14, 2017
Merged
Conversation
* We set this at bot.start(), revert to previous setting in a final block * We default to -1 given that output can't be explored out of the box - otherwise data can remain hidden and inaccessible
2135e9d to
ca365bd
Compare
Contributor
Author
|
Not sure why I called it a work in progress, this is ready for review if you're interested - I'm just assuming there might be more, or a better route given my limited knowledge of the codebase : ) |
Member
|
Thanks @RamblingCookieMonster! I'll take a look. |
Member
|
LGTM! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hiyo!
This simply adds a FormatEnumerationLimitOverride key to the bot configuration, with a default of -1
Ping me if you want to have any input on changes that you'd prefer (in direction or implementation) - cheers!
Description
Not sure if this is the direction you were looking for, or the right way to go about it if so. The saving current value / reverting in a final block, and using the global scope is based on this
I added a parameter help bit to
New-PoshBotConfiguration, but didn't update any example output fromGet-PoshBotConfiguration(seems nice to have but superficial)Related Issue
#47
Motivation and Context
See #47
How Has This Been Tested?
Manually tested by loading bot with no initial change to config; expected enumeration limit of -1 was correctly set
Manually tested by loading bot with config FormatEnumerationLimitOverride set to 6 (not default); expected limit of 6 was correctly set
Types of changes
Checklist: