Fix for: to_dict() raises "Object of type range is not JSON serializable" for some svd files#176
Merged
posborne merged 1 commit intocmsis-svd:masterfrom Oct 6, 2023
ckudera:master
Merged
Fix for: to_dict() raises "Object of type range is not JSON serializable" for some svd files#176posborne merged 1 commit intocmsis-svd:masterfrom ckudera:master
posborne merged 1 commit intocmsis-svd:masterfrom
ckudera:master
Conversation
Collaborator
|
Thanks for the change, this is probably a result of the original impl having an assumption based on how |
Collaborator
|
Going to bypass CI since we're dropping the failing version. Other changes upstream will regress this particular test but that can be fixed as part of #180. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #175 and adds a test