add support for converting to null#53
Merged
ddeboer merged 1 commit intoportphp:masterfrom Aug 31, 2017
Merged
Conversation
33558bf to
b11562d
Compare
ddeboer
requested changes
Aug 31, 2017
| public function __invoke($input) | ||
| { | ||
| if (!isset($this->mapping[$input])) { | ||
| if (!\array_key_exists($input, $this->mapping)) { |
Member
There was a problem hiding this comment.
array_key_exists is slower than isset, so can you change this to:
if (isset(…) || array_key_exists(…)) {
return …
}
throw …
Contributor
Author
There was a problem hiding this comment.
hah, Premature Optimization?
You're the boss!
b11562d to
315d58e
Compare
ddeboer
approved these changes
Aug 31, 2017
Member
|
Thanks! |
Contributor
Author
|
thanks for the merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MappingValueConverterdidn't support converting a value tonull, which this PR addresses.