Make FontSystem not self-referencing, second try#95
Closed
geieredgar wants to merge 1 commit intopop-os:mainfrom
Closed
Make FontSystem not self-referencing, second try#95geieredgar wants to merge 1 commit intopop-os:mainfrom
FontSystem not self-referencing, second try#95geieredgar wants to merge 1 commit intopop-os:mainfrom
Conversation
96b5221 to
6e9b911
Compare
6e9b911 to
bff5aaa
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like #89, this makes the
stdimplementation ofFontSystemnot self-referencing, which in turn allows defining adb_mutmethod for mutable access to the underlyingfontdb::Database(requested in #75).Unlike #89, this makes
Fontself-referencing. Fonts are cached like before, so the performance should stay the same. The only impact on performance should be thatFaceInfois cloned and stored inside theFontto remove the need to borrow fromfontdb::Database.