WIP Multiple font size / line height spans#150
Closed
tigregalis wants to merge 26 commits intopop-os:mainfrom
Closed
WIP Multiple font size / line height spans#150tigregalis wants to merge 26 commits intopop-os:mainfrom
tigregalis wants to merge 26 commits intopop-os:mainfrom
Conversation
15 tasks
12 tasks
87be9d7 to
506c384
Compare
Contributor
|
Linking my PR that continues this PR: tigregalis#1 |
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current status: Almost done. Working, with some fixes for the editing required.
Fixes #64
Implement specifying multiple font sizes and/or line heights.
Media8mute.mp4
TODO:
enum LineHeightline_heights()Metricsiced(incompatible API))termion, see Update terminal example usingcolored#129)Future work:
Attrs:color_opt,metadata,font_size,line_heightBuffershould have a defaultAttrsAttrsin aBufferAttrsmore carefullyQuestions:
Hashimpl ofAttrsinclude line height?Metricsbe restored as a property ofAttrs, with definitionMetrics { font_size: f32, line_height: LineHeight }?