Skip to content

Remove optimization phases, update package.yaml-s#382

Merged
googleson78 merged 2 commits intomasterfrom
remove-extra-phases
Oct 23, 2020
Merged

Remove optimization phases, update package.yaml-s#382
googleson78 merged 2 commits intomasterfrom
remove-extra-phases

Conversation

@TheMatten
Copy link
Copy Markdown
Collaborator

@TheMatten TheMatten commented Oct 23, 2020

Fixes polysemy-research/polysemy-zoo#65 by removing optimization phases, which weren't really used up until now and don't solve the original problem anyway. Additionally I've fixed warnings in package.yaml files and fixed bound on th-abstraction being modified only in polysemy.cabal.

@TheMatten TheMatten requested a review from googleson78 October 23, 2020 08:10
@googleson78
Copy link
Copy Markdown
Member

googleson78 commented Oct 23, 2020

travis not passing, but of course it doesn't show up in the PR for some reason :)
https://travis-ci.org/github/polysemy-research/polysemy/builds/738241715

googleson78
googleson78 reviewed Oct 23, 2020
View reviewed changes
@TheMatten
Copy link
Copy Markdown
Collaborator Author

TheMatten commented Oct 23, 2020

travis not passing, but of course it doesn't show up in the PR for some reason :)
https://travis-ci.org/github/polysemy-research/polysemy/builds/738241715

Warning: Packages using 'cabal-version: 2.0' and the autogenerated module
Paths_* must include it also on the 'autogen-modules' field besides
'exposed-modules' and 'other-modules'. This specifies that the module does not
come with the package and is generated on setup. Modules built with a custom
Setup.hs script also go here to ensure that commands like sdist don't fail.

So I guess I should just add them to generated-other-modules too? 😄

@TheMatten TheMatten mentioned this pull request Oct 23, 2020
Closed
@TheMatten
Copy link
Copy Markdown
Collaborator Author

TheMatten commented Oct 23, 2020

CI is green now 🎉

@googleson78 googleson78 merged commit 3399de1 into master Oct 23, 2020
@isovector isovector deleted the remove-extra-phases branch October 19, 2021 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@googleson78 googleson78 googleson78 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ghc 8.10 and ghc-prim bound

2 participants

@TheMatten @googleson78