raise2Under and raise3Under#369
Merged
googleson78 merged 1 commit intopolysemy-research:masterfrom Jul 28, 2020
Merged
Conversation
These combinators are like raiseUnder, but place the new effect at the second and third position in the list.
TheMatten
approved these changes
Jul 28, 2020
Collaborator
KingoftheHomeless
approved these changes
Jul 28, 2020
Collaborator
KingoftheHomeless
left a comment
There was a problem hiding this comment.
The names are unfortunate. The raiseNUnder and raiseUnderN functions should have their names swapped. Unfortunately, we can't do that since it could cause very nefarious breakage. Perhaps for 2.0. For the moment, this is good enough.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These combinators are like raiseUnder, but place the new effect at the
second and third position in the list.
This is for interpreters that consume two effects, delegating to two other interpreters, who share a dependency which is then interpreted by the outer interpreter.
Please advise on what else to do, naming, general sense and so on!