Skip to content

Build with 8.10#337

Merged
googleson78 merged 3 commits intomasterfrom
336_build-with-810
Apr 29, 2020
Merged

Build with 8.10#337
googleson78 merged 3 commits intomasterfrom
336_build-with-810

Conversation

@googleson78
Copy link
Copy Markdown
Member

@googleson78 googleson78 commented Apr 28, 2020

Fixes #336

  • Ct (and friends) now comes from Constraints
  • There was an ifdef'd part that uses a function "bool" which isn't imported when the ifdef triggers

* Ct (and friends) now comes from Constraints
* There was an ifdef'd part that uses a function "bool" which isn't
  imported when the ifdef triggers
import Polysemy.Plugin.Fundep
#if __GLASGOW_HASKELL__ >= 810
import Polysemy.Plugin.Phases
import Data.Bool (bool)
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheMatten could you take a look at this? I took a guess as to which bool is supposed to be used here, but I don't really know what the code does, and blame says you wrote the part with bool

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it should be that one 👍

@googleson78 googleson78 merged commit 5fe9398 into master Apr 29, 2020
@isovector isovector deleted the 336_build-with-810 branch October 19, 2021 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failure on GHC 8.10 (win64)

2 participants