Merged
Conversation
Owner
|
Looks good, thanks. I will add a route in relayer and test it at first. With that route you can complete the API call |
Owner
|
Here is the new api for that: 7a3be18 |
Collaborator
Author
Nice, I'll wire it up. |
# Conflicts: # code/client/src/pages/Show.jsx
Owner
|
Well it is a lot more complicated than I anticipated. But I got it done. |
Owner
|
On the UI side I made a few adjustments: instead modal I continued using AnimatedSection in the same style as Transfer screen, so we can keep things consistent. Also it needs an OTP code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@polymorpher I've added a modal for setting the wallet's recovery address (if not already set).
I'm not sure what needs to happen to set the address in the contract from here. I'm happy to update it if you point me in the right direction. I'm also happy for you to take over from here. Whichever you're more comfortable with 👍