Looks good. Will do some testing in the next few days, but I think this is ready to merge

I am using it since and I had no issue with it (This patch also applied: #911).
@patrick96 Did you have time to check it ?

Sorry, I didn't have time yet. I'll try to get to it soon

Thanks for the feedback, I'll try to debug it later this week.

Hey @Kokan do you still plan on working on this? If not, we can add it to our own backlog and fix the last issue ourselves, I don't think it would be too bad.

I do not think I am going to fix it soon, as I am not using currently polybar.

Alright. We'll try to finish this when we get time for it.

@patrick96 I tried to debug this and cannot reproduce the segfault anymore after rebasing onto current master.

If format-offline is not specified at all, it defaults to an empty string (or so), but creates the module.
If format-offline does not contain <label-offline> but <label> it errors out of the module-creation with error: Disabling module "github" (reason: <label> is not a valid format tag for "format-offline").
A string without tokens is (as expected) taken as is without complaint.

I for one think this is sane behaviour and in working condition after a rebase.

Hey @kronn, I just did a rebase and recompiled and am still getting the segfault.

Here is the config I used:

[bar/example]
modules-left = gh

[module/gh]
type = internal/github

token = 

EDIT: The behavior you described is indeed sane were it not for the segfault ;)