fix(backlight): Poll if necessary #3028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3028 +/- ##
==========================================
- Coverage 12.71% 12.69% -0.02%
==========================================
Files 160 160
Lines 12517 12530 +13
==========================================
Hits 1591 1591
- Misses 10926 10939 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
|
4b189dd to
756b9fe
Compare
The `backlight` file seems to not receive modification events for inotify (it does receive other events though). These other events still trigger an update, but the value read is still the old value because the events arrive just slightly before the file is updated. The new `poll-interval` setting will inject an event every X seconds to force an update. If the actual_brightness file is used, the interval is set to 0 and thus turned off. This does not add any more wakeups to the module, the inotify modules wake up every second anyway and during that time, the interval is checked. Fixes polybar#2835
756b9fe to
7472356
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
The
backlightfile seems to not receive modification events for inotify (it does receive other events though).These other events still trigger an update, but the value read is still the old value because the events arrive just slightly before the file is updated.
The new
poll-intervalsetting will inject an event every X seconds to force an update.If the actual_brightness file is used, the interval is set to 0 and thus turned off.
This does not add any more wakeups to the module, the inotify modules wake up every second anyway and during that time, the interval is checked.
Related Issues & Documents
Fixes #2835
Documentation (check all applicable)
Document
poll-intervaland maybe better describe the recommended settings.