fix: Handle X events before polling for IO #2820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
05039da to
7bc1d15
Compare
Polling the XCB file descriptor for X events doesn't detect events that are already in XCB's event queue but not yet handled. If this happens, the eventloop polls for IO and the queued events wait until another event arrives, causing some desyncs in the bar. This can easily happen if something (e.g. a click event) triggers some xcb calls, which as a consequence buffer some incoming events. We "fix" this by adding a libuv prepare handle (which runs right before polling for IO) that processes pending X events.
7bc1d15 to
7bab54c
Compare
Codecov Report
@@ Coverage Diff @@
## master #2820 +/- ##
==========================================
- Coverage 13.44% 13.42% -0.02%
==========================================
Files 151 151
Lines 11465 11482 +17
==========================================
Hits 1541 1541
- Misses 9924 9941 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Polling the XCB file descriptor for X events doesn't detect events that
are already in XCB's event queue but not yet handled.
If this happens, the eventloop polls for IO and the queued events wait
until another event arrives, causing some desyncs in the bar.
This can easily happen if something (e.g. a click event) triggers some
xcb calls, which as a consequence buffer some incoming events.
We "fix" this by adding a libuv prepare handle (which runs right before
polling for IO) that processes pending X events.
Related Issues & Documents
This caused some issues in #2609
Documentation (check all applicable)