fix: Crash on root pixmap and window depth mismatch #2813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The background_manager used the root window depth for creating its pixmaps, but when the root pixmap has a different depth, this causes the copy_area_checked call to fail and crash the bar. We now load the root pixmap before finding the visual and creating the slice pixmaps. Fixes polybar#2798
35dc550 to
29211e8
Compare
Codecov Report
@@ Coverage Diff @@
## master #2813 +/- ##
==========================================
- Coverage 13.49% 13.44% -0.06%
==========================================
Files 152 151 -1
Lines 11422 11465 +43
==========================================
Hits 1541 1541
- Misses 9881 9924 +43
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
The background_manager used the root window depth for creating its
pixmaps, but when the root pixmap has a different depth, this causes the
copy_area_checked call to fail and crash the bar.
We now load the root pixmap before finding the visual and creating the
slice pixmaps.
Related Issues & Documents
Fixes #2798
Documentation (check all applicable)