fix(renderer): Small gaps when rendering emojis #2802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If any rendered text uses a non-integer number of pixels (often emojis), rendering of subsequent text blocks will start between pixels which results in small gaps in the background and over/underline colors caused by cairo only rendering at fractional-intensity in the beginning and end pixel. Simply rounding up text width can solve this. Fixes polybar#2785
d91a3eb to
ce4190f
Compare
Codecov Report
@@ Coverage Diff @@
## master #2802 +/- ##
==========================================
- Coverage 13.49% 13.49% -0.01%
==========================================
Files 152 152
Lines 11416 11422 +6
==========================================
Hits 1541 1541
- Misses 9875 9881 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
patrick96
commented
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
If any rendered text uses a non-integer number of pixels (often emojis),
rendering of subsequent text blocks will start between pixels which
results in small gaps in the background and over/underline colors caused
by cairo only rendering at fractional-intensity in the beginning and end
pixel.
Simply rounding up text width can solve this.
Related Issues & Documents
Fixes #2785
Documentation (check all applicable)