Skip to content

backlight: auto-detect default card #2728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
patrick96 merged 5 commits into from
Jun 16, 2022
Merged

backlight: auto-detect default card #2728

patrick96 merged 5 commits into from
Jun 16, 2022

Conversation

@raffael0
Copy link
Contributor

@raffael0 raffael0 commented May 23, 2022 •
edited
Loading

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Other: Replace this with a description of the type of this PR

Description

Implements the automatic detection of cards for the backlight module(See #2572)
When no card is specified, the backlight module looks for a viable card in /sys/class/backlight/ and uses that.

Related Issues & Documents

Implements part of #2572

Documentation (check all applicable)

  • This PR requires changes to the Wiki documentation (describe the changes)
  • This PR requires changes to the documentation inside the git repo (please add them to the PR).
  • Does not require documentation changes
    in modules:backlight the following lines should be changed from:
; Use the following command to list available cards:
; $ ls -1 /sys/class/backlight/
card = intel_backlight

to:

; Use the following command to list available cards:
; $ ls -1 /sys/class/backlight/
; Default: first usable card in /sys/class/backlight
card = intel_backlight

@raffael0 raffael0 changed the title auto-detect default backlight backlight: auto-detect default card May 23, 2022
@codecov
Copy link

codecov bot commented May 23, 2022 •
edited
Loading

Codecov Report

Merging #2728 (dd615f8) into master (1ee11f7) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2728      +/-   ##
==========================================
- Coverage   13.56%   13.54%   -0.03%     
==========================================
  Files         152      152              
  Lines       11357    11381      +24     
==========================================
  Hits         1541     1541              
- Misses       9816     9840      +24
Flag Coverage Δ
unittests 13.54% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/modules/backlight.cpp 0.00% <0.00%> (ø)
src/components/bar.cpp 0.00% <0.00%> (ø)
src/x11/tray_manager.cpp 0.00% <0.00%> (ø)
include/components/config.hpp 0.00% <0.00%> (ø)
src/components/controller.cpp 0.00% <0.00%> (ø)
include/components/controller.hpp 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ee11f7...dd615f8. Read the comment docs.

patrick96
patrick96 requested changes Jun 14, 2022
View reviewed changes
Copy link
Member

@patrick96 patrick96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Just some minor comments.

@raffael0 raffael0 requested a review from patrick96 June 14, 2022 13:34
patrick96
patrick96 requested changes Jun 15, 2022
View reviewed changes
@raffael0 raffael0 requested a review from patrick96 June 16, 2022 10:32
@patrick96 patrick96 added this to the 3.7.0 milestone Jun 16, 2022
patrick96
patrick96 approved these changes Jun 16, 2022
View reviewed changes
Copy link
Member

@patrick96 patrick96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead and fixed the changelog formatting. Everything looks good now!

@raffael0
Copy link
Contributor Author

raffael0 commented Jun 16, 2022

Thanks! No idea how that always keeps happening. Must be some IDE thing

@patrick96
Copy link
Member

patrick96 commented Jun 16, 2022

Yeah, many IDEs do auto-formatting on save.

@patrick96 patrick96 merged commit f3e27a2 into polybar:master Jun 16, 2022
@patrick96 patrick96 mentioned this pull request Jun 16, 2022
Open
@mrquincle
Copy link

mrquincle commented Jul 20, 2022

Super neat. On my system it all the time switches from amdgpu_bl0 to amdgpu_bl1, so this would be a time-saver.

@patrick96 patrick96 mentioned this pull request Nov 5, 2023
Merged
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patrick96 patrick96 patrick96 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.7.0

Development

Successfully merging this pull request may close these issues.

3 participants

@raffael0 @patrick96 @mrquincle